Add few shell filters #84179
Open
Add few shell filters #84179
+42
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Regulators
area: I2C
area: DAC
zephyrbot
requested review from
aasinclair,
danieldegrasse,
gmarull,
martinjaeger and
teburd
pdgendt
previously approved these changes
Jan 17, 2025
kartben
previously approved these changes
Jan 17, 2025
keith-zephyr
previously approved these changes
Jan 17, 2025
yishai1999
reviewed
Jan 18, 2025
drivers/dac/dac_shell.c
Outdated
| @@ -94,14 +94,31 @@ static int cmd_write_value(const struct shell *sh, size_t argc, char **argv) | |||
| return 0; | |||
| } | |||
|
|
|||
| static bool device_is_dac(const struct device *dev) | |||
| { | |||
| return device_is_ready(dev) && DEVICE_API_IS(dac, dev); | |||
There was a problem hiding this comment.
shell_device_filter already checks device_is_ready so this is superfluous
There was a problem hiding this comment.
Hey you are right! I had copy pasted this from other drivers, removed from all of these and added an extra patch to clean up the existing ones. Thanks!
Add shell device name filtering using DEVICE_API_IS. Signed-off-by: Fabio Baltieri <[email protected]>
Add shell device name filtering using DEVICE_API_IS. Signed-off-by: Fabio Baltieri <[email protected]>
Add shell device name filtering using DEVICE_API_IS. Signed-off-by: Fabio Baltieri <[email protected]>
Drop few redundant device_is_ready for functions that are only used as argument to shell_device_filter, as shell_device_filter checks for that alrady. Suggested-by: Yishai Jaffe <[email protected]> Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
dismissed stale reviews from keith-zephyr, kartben, and pdgendt
via
705c71e
zephyrbot
added
area: Comparator
area: LED
zephyrbot
requested review from
bbilas,
bjarki-andreasen,
Mani-Sadhasivam and
simonguinot
yishai1999
reviewed
Jan 19, 2025
| @@ -69,7 +69,7 @@ static void print_callback(const struct device *dev, const enum stepper_event ev | |||
|
|
|||
| static bool stepper_device_check(const struct device *dev) | |||
There was a problem hiding this comment.
Maybe change the function name to device_is_stepper to match the rest?
pdgendt
reviewed
Jan 19, 2025
| @@ -336,9 +336,14 @@ static int cmd_i2c_speed(const struct shell *shell_ctx, size_t argc, char **argv | |||
| return 0; | |||
| } | |||
|
|
|||
| static bool device_is_i2c(const struct device *dev) | |||
| { | |||
| return DEVICE_API_IS(i2c, dev); | |||
There was a problem hiding this comment.
As i3c extends the i2c API, this should be special cased here.
Suggested change
| return DEVICE_API_IS(i2c, dev); | |
| return DEVICE_API_IS(i2c, dev) || DEVICE_API_IS(i3c, dev); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add few shell filter functions, i2c, regulator and dac.